search

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
558 stars 164 forks source link

Ramps found with pathological data during ramp fitting that should be flagged earlier #8332

Open stscijgbot-jp opened 6 months ago

stscijgbot-jp commented 6 months ago

Issue JP-3561 was created on JIRA by Kenneth MacDonald:

During regression, in the jump file used to create test data to be checked against a truth file

test_nirspec_irs2_detector1_rtdata_modulecurrent/jw0010010_11010_nrs1_chimera_rateints.fits

has invalid data that is flagged as GOOD for ramp fitting.  As an example pixel, in the jump file that is used to create the above rateints file, the pixel ramp for (172, 682) has the following data with the following DQ flags when entering ramp fitting:

 

    data[0, :, 172, 682] = np.array([-2.4926656e+07, -1.1489452e+09, -6.4948192e+08, -1.1097796e+08,  4.0666160e+06,  1.7508144e+08,  1.8980417e+09])

    gdq[0, :, 172, 682] = np.array([0, 4, 4, 4, 0, 4, 4])

stscijgbot-jp commented 2 months ago

Comment by David Law on JIRA:

Kenneth MacDonald This is simulated data, right?  Do you think this is best addressed by updating the truth test file to use flight data instead, or is it showing us something about the code that needs to be fixed for flight data as well?