search

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
546 stars 160 forks source link

Revise coron3 alignment step #8492

Open stscijgbot-jp opened 1 month ago

stscijgbot-jp commented 1 month ago

Issue JP-3628 was created on JIRA by David Law:

Per input from Marshall Perrin :

A low-hanging fruit for a pipeline improvement is actually a major simplification: The coron3 pipeline “align refs” step assumes that the alignment needs to be done separately for each science integration. THis was a design decision made long pre-flight in the conservative expectation that we might see drifts  during an observation in line-of-sight pointing or in PSF properties. In practice we see neither of those at substantial levels. SpaceKLIP makes the simpler assumption that all the science integrations have the same pointing, so it’s sufficient to align all the references to the first science integration. I think this ends up dramatically reducing the runtime for the whole calculation.  It seems to me this is an area in which the jwst pipeline is over-complexified because of preflight lack of knowledge, and could be simplified and sped up.

stscijgbot-jp commented 4 days ago

Comment by David Law on JIRA:

Seems straight forward to me; modify the align_refs step to apply whatever shifts are relevant to the first science integration to all integrations instead of deriving them independently.

Pinging Julien Girard Jonathan Aguilar Marshall Perrin Dean Hines for any further input.

stscijgbot-jp commented 4 days ago

Comment by Julien Girard on JIRA:

Yes, it is a good idea. The level 3 products here are largely used for quick look purposes so assuming all science integrations are aligned is ok. The current default could become an option.