Open emolter opened 5 months ago
Hi @nden, this is a rough first draft. I'm hoping you could give me your feedback/opinion on the following:
test_metadata.py
and put all the tests of the names in there? I see the benefit being enhanced readability, but the drawback would be that the WCS objects would each have to be created again from scratch in those tests, so the overall runtime would be substantially longer.Attention: Patch coverage is 97.84173%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 57.86%. Comparing base (
4179c09
) to head (6d077e6
). Report is 6 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
jwst/assign_wcs/miri.py | 87.50% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Resolves JP-3607
Closes #8444
The astropy GWCS module permits assignment of descriptive names of transforms, as well as descriptive labels for their inputs and outputs . These make it much easier to understand what a transform is doing, and which transform to use in what instance(s). This PR adds those descriptive names, inputs, and outputs.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release section