spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
570 stars 167 forks source link

JP-3607: descriptive names, inputs, and outputs for wcs transforms #8524

Open emolter opened 5 months ago

emolter commented 5 months ago

Resolves JP-3607

Closes #8444

The astropy GWCS module permits assignment of descriptive names of transforms, as well as descriptive labels for their inputs and outputs . These make it much easier to understand what a transform is doing, and which transform to use in what instance(s). This PR adds those descriptive names, inputs, and outputs.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

emolter commented 5 months ago

Hi @nden, this is a rough first draft. I'm hoping you could give me your feedback/opinion on the following:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 97.84173% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 57.86%. Comparing base (4179c09) to head (6d077e6). Report is 6 commits behind head on master.

Files Patch % Lines
jwst/assign_wcs/miri.py 87.50% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8524 +/- ## ========================================== - Coverage 57.97% 57.86% -0.12% ========================================== Files 387 388 +1 Lines 38830 39032 +202 ========================================== + Hits 22513 22584 +71 - Misses 16317 16448 +131 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.