Closed melanieclarke closed 5 months ago
Regression tests started here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1499/
Looking at regtest results...
I was expecting the changes to test_against_standard[pool_021_tso] and test_against_standard[pool_022_tso_noflag]: I updated the pool files in the repository to give them the new values needed to plan NIRSpec TSO. The associations are still created, they just have different names.
I did not expect the differences for these:
But it looks like all of these are using early pool files which have FXD_SLIT = null, so there are TSO associations that are no longer being created, even though they would be if FXD_SLIT was populated.
I think the other changes are unrelated. I'm not sure why the jwst.associations.tests.test_level3_duplicate test failed, though. I can't reproduce it locally, on my branch or main.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 58.13%. Comparing base (
b7e0b10
) to head (4ab595a
). Report is 317 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Resolves JP-3173
Closes #8240
NIRSpec TSO associations are created via the general TSO rules (Asn_Lv2SpecTSO and Asn_Lv3TSO), which do not currently have a check on the valid optical paths for NIRSpec. This results in associations being created for NRS2 in some modes for which no light falls on that detector (e.g. S1600A1, prism, clear). This PR adds NIRSpec optical path constraints to the TSO rules.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release section