spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
570 stars 167 forks source link

remove name_format usage in wfs_combine #8539

Closed braingram closed 5 months ago

braingram commented 5 months ago

This PR replaces usage of name_format in wfs_combine with make_output_path. The resulting filenames saved by the step are the same (as is tested in the test_nircam_wfs_image regression test). This PR removes the only use of name_format to allow its removal in stpipe to work towards simplifying the file naming code.

Regression tests show only unrelated errors and no failures of test_nircam_wfs_image. https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1502/

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.02%. Comparing base (4179c09) to head (b7e0b10). Report is 326 commits behind head on master.

Files with missing lines Patch % Lines
jwst/wfs_combine/wfs_combine_step.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8539 +/- ## ========================================== + Coverage 57.97% 58.02% +0.04% ========================================== Files 387 388 +1 Lines 38830 38977 +147 ========================================== + Hits 22513 22617 +104 - Misses 16317 16360 +43 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.