Closed braingram closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 58.63%. Comparing base (
dba65ae
) to head (a7deded
). Report is 223 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
jwst.associations.lib.log_config globally sets the logging class to
MultilineLogger
which can cause seemingly unrelated tests to fail: https://github.com/spacetelescope/stpipe/actions/runs/9445531594/job/26087417184#step:10:189The failure revealed a bug in the ami log messages (
end
is not a supported kwarg for these calls).This PR also removes
MultilineLogger
and the global call tosetLoggerClass
.This class was added in the "inital commit": https://github.com/spacetelescope/jwst/commit/5915b0e919be1e3393fd0ba74ff9106de77a4a1e#diff-9e38d1ac7b11ff469184d069a47776082c49c376e91e3b8dbb9e3b3872a6627bR177 and will change other logging if the association module is imported. For example:
produces:
removing
import jwst.associations.lib.log_config
produces:(note the rather extensive log formatting that stpipe introduces, this is not part of this PR). With this PR the output (with the
jwst.association.lib.log_config
) is:(and the same if
jwst.associations.lib.log_config
is not imported).Fixes https://github.com/spacetelescope/jwst/issues/6407 and is an alternative to https://github.com/spacetelescope/jwst/pull/7616
Regression tests running at: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1534/
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release section