search

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
570 stars 167 forks source link

Update the JWST pipeline to accommodate the new likelihood algorithm in ramp fitting #8560

Closed stscijgbot-jp closed 2 months ago

stscijgbot-jp commented 5 months ago

Issue JP-3658 was created on JIRA by Kenneth MacDonald:

A new algorithm has been added to the ramp fitting module in STCAL that the JWST pipeline can select (JP-3576).

 

The likelihood algorithm does its own jump detection during the ramp fitting processing, so the existing separate jump detection algorithm done in the pipeline should be skipped if the likelihood algorithm is selected for ramp fitting.  

 

Additionally, if the likelihood algorithm is selected the NGROUPS of the data should be checked.  If NGROUPS is 3 or less, then the OLS ramp fitting algorithm should be used and the normal pipeline jump detection algorithm should be run.  The minimum ramp size for the likelihood to run correctly is 4 groups per ramp.

stscijgbot-jp commented 2 months ago

Comment by Melanie Clarke on JIRA:

Changes implemented in #8631

It was decided in development and testing to not turn off jump by default, since the flags might be needed for the clean_flicker_noise step.  The changes here are just to make the LIKELY algorithm available, and default to OLS_C if NGROUPS < 4.

stscijgbot-jp commented 1 month ago

Comment by David Law on JIRA:

Confirmed that the new step is working; further testing will take place in dedicated ticket https://jira.stsci.edu/browse/JP-3765