JP-3648: Move NIRSpec FS point source position assignment out of wavecorr

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope

https://jwst-pipeline.readthedocs.io/en/latest/

Other

561 stars 167 forks source link

JP-3648: Move NIRSpec FS point source position assignment out of wavecorr #8569

Closed emolter closed 3 months ago

emolter commented 3 months ago

Resolves JP-3648

Closes #8536

This PR addresses moving the assignment of the slit.source_xpos and slit.source_ypos attributes from the wavecorr step to the extract_2d step. This change allows the wavecorr step to be skipped without causing failures downstream (extract_2d is not skipped for fixed-slit data).

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

[x] added entry in CHANGES.rst within the relevant release section
[x] updated or added relevant tests
[x] updated relevant documentation
[x] added relevant milestone
[x] added relevant label(s)
[x] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR
[x] All comments are resolved
[x] Make sure the JIRA ticket is resolved properly

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 86.36364% with 9 lines in your changes missing coverage. Please review.

Project coverage is 59.57%. Comparing base (23fb5cd) to head (c0d1d4c).

Files with missing lines	Patch %	Lines
jwst/extract_2d/nirspec.py	86.04%	6 Missing :warning:
jwst/wavecorr/wavecorr_step.py	66.66%	3 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #8569 +/- ## ========================================== + Coverage 59.54% 59.57% +0.02% ========================================== Files 391 391 Lines 39292 39309 +17 ========================================== + Hits 23396 23417 +21 + Misses 15896 15892 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

emolter commented 3 months ago

regression tests started here

emolter commented 3 months ago

Fresh regtest run started here

emolter commented 3 months ago

All the regtest failures are expected: they only pertain to the existence of SRCXPOS and SRCYPOS header keywords and display no changes to any data.

emolter commented 3 months ago

~~New round of regression tests started here~~

out-of-date as it was not using stdatamodels>2.0; see below

emolter commented 3 months ago

re-starting regression test run after rebasing to include stdatamodels>2.0

emolter commented 3 months ago

All of the regtest failures are once again just related to extra header keywords SRCXPOS and SRCYPOS, which are expected