search

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
545 stars 158 forks source link

Update stcal requirement from <1.6.0 to <1.8.0 #8571

Closed dependabot[bot] closed 2 weeks ago

dependabot[bot] commented 2 weeks ago

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
braingram commented 2 weeks ago

@zacharyburnett do we still use this requirements-max.txt file?

zacharyburnett commented 2 weeks ago

@zacharyburnett do we still use this requirements-max.txt file?

For the moment I think Jenkins uses it, but GHA does not. I forget why we needed to constrain it in regtests in the first place.

braingram commented 2 weeks ago

Weird, the requirement for stcal in requirements-max.txt is stcal<1.6.0 yet the one in the pyproject.toml is stcal>=1.7.1,<1.8.0. These don't overlap :-/

zacharyburnett commented 2 weeks ago

I think it's safe to merge this, as far as I know