Closed emolter closed 1 week ago
new regtests started here
edit: regtest failures are unrelated
Attention: Patch coverage is 0%
with 11 lines
in your changes missing coverage. Please review.
Project coverage is 59.54%. Comparing base (
b1baedb
) to head (23fb5cd
). Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
jwst/pipeline/calwebb_tso3.py | 0.00% | 11 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@emolter I've put some test data in /grp/jwst/ssb/chartreuse/dms_bugs/jp-3665/ that can be used to verify that this fix works. I've verified that using jwst/master to run "strun calwebb_tso3 jw02113-o002_tso3_00001_asn.json" duplicates the error seen in operations. Try the same command using this PR branch.
@hbushouse yes it runs fine. I also tested it on jw02113-o002_20240619t062654_tso3_00001_asn.json
. Do you think I should write a regtest for this fix with one of these datasets?
The following messages are produced:
2024-06-24 15:18:38,967 - stpipe.Tso3Pipeline.extract_1d - INFO - Input is a NIRISS SOSS observation, the specialized SOSS extraction (ATOCA) will be used.
2024-06-24 15:18:38,967 - stpipe.Tso3Pipeline.extract_1d - INFO - Exposure is through the GR700XD + CLEAR (science).
2024-06-24 15:18:38,967 - stpipe.Tso3Pipeline.extract_1d - ERROR - The SOSS extraction is implemented for the SUBSTRIP256and SUBSTRIP96 subarrays only. Subarray is currently FULL.
2024-06-24 15:18:38,968 - stpipe.Tso3Pipeline.extract_1d - ERROR - Extract1dStep will be skipped.
2024-06-24 15:18:38,968 - stpipe.Tso3Pipeline.extract_1d - INFO - Step extract_1d done
2024-06-24 15:18:38,969 - stpipe.Tso3Pipeline - WARNING - extract_1d step could not be completed for any integrations
2024-06-24 15:18:38,969 - stpipe.Tso3Pipeline - WARNING - x1dints products will not be created.
2024-06-24 15:18:38,969 - stpipe.Tso3Pipeline - WARNING - Could not create a photometric catalog; all results are null
2024-06-24 15:18:38,969 - stpipe.Tso3Pipeline - INFO - Step Tso3Pipeline done
Resolves JP-3665
Closes #8581
This PR addresses a bug in the TSO3 pipeline where NIRISS SOSS data for which 1-D spectra could not be extracted were raising errors, instead of exiting the pipeline gracefully. This update makes it so that saving x1dints files is not attempted in this case, and the rest of the TSO3 pipeline is skipped.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release section