JP-3660: extract1d _coalesce_bounds fix

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope

https://jwst-pipeline.readthedocs.io/en/latest/

Other

561 stars 167 forks source link

JP-3660: extract1d _coalesce_bounds fix #8586

Closed t-brandt closed 3 months ago

t-brandt commented 3 months ago

Resolves JP-3660

Closes #8564

This PR fixes a bug/removes an unacknowledged assumption in _coalesce_bounds within extract1d.py, where incorrect bounds can be returned if several intervals are passed to the function to be combined, and one interval is entirely contained within another.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

[x] added entry in CHANGES.rst within the relevant release section
[ ] updated or added relevant tests
[ ] updated relevant documentation
[x] added relevant milestone
[x] added relevant label(s)
[x] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR
[ ] All comments are resolved
[x] Make sure the JIRA ticket is resolved properly

hbushouse commented 3 months ago

Started a regression test run at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1554 Theoretically we expect no changes in results, since this only addresses a potential corner case that does not currently exist in normal processing.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.54%. Comparing base (d668926) to head (2b5828f). Report is 465 commits behind head on master.

Files with missing lines	Patch %	Lines
jwst/extract_1d/extract1d.py	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #8586 +/- ## ========================================== + Coverage 59.51% 59.54% +0.03% ========================================== Files 391 391 Lines 39254 39286 +32 ========================================== + Hits 23362 23394 +32 Misses 15892 15892 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hbushouse commented 3 months ago

Started a regression test run at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1554 Theoretically we expect no changes in results, since this only addresses a potential corner case that does not currently exist in normal processing.

4 failures that are unrelated. So this looks OK.