JP-3593: Fix 2nd/3rd group saturation for NIRSpec IRS2

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope

https://jwst-pipeline.readthedocs.io/en/latest/

Other

570 stars 167 forks source link

JP-3593: Fix 2nd/3rd group saturation for NIRSpec IRS2 #8593

Closed drlaw1558 closed 4 months ago

drlaw1558 commented 4 months ago

Resolves JP-3593 by adding in a set of checks for pixels that saturate in the 3rd group that already saturated in the 2nd group but were diluted by the group average. Only affects NIRSpec IRS2 data.

Closes #8413

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

[x] added entry in CHANGES.rst within the relevant release section
[x] updated or added relevant tests
[x] updated relevant documentation
[x] added relevant milestone
[x] added relevant label(s)
[x] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR
[x] All comments are resolved
[x] Make sure the JIRA ticket is resolved properly

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.55%. Comparing base (23fb5cd) to head (5bd5e93). Report is 452 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #8593 +/- ## ========================================== + Coverage 59.54% 59.55% +0.01% ========================================== Files 391 391 Lines 39292 39307 +15 ========================================== + Hits 23396 23411 +15 Misses 15896 15896 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hbushouse commented 4 months ago

Started a regtest run at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1559

hbushouse commented 4 months ago

@drlaw1558 What about RTD updates? Probably should mention this detail in the saturation step docs.

hbushouse commented 4 months ago

Started a regtest run at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1559

I've confirmed that all ~200 failures in the regtest run are unrelated and due to the use of an older version of stdatamodels in the PR branch. So this looks OK.