remove non-working or out-dated scripts

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope

https://jwst-pipeline.readthedocs.io/en/latest/

Other

570 stars 167 forks source link

remove non-working or out-dated scripts #8619

Closed braingram closed 4 months ago

braingram commented 4 months ago

This PR removes a number of scripts that are:

not working due to API changes (for example resample.py)
redundant to strun (for example dq_init.py)

Regression tests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1573/ showed only the 2 command, random, and unrelated errors

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

[ ] added entry in CHANGES.rst within the relevant release section
[ ] updated or added relevant tests
[ ] updated relevant documentation
[ ] added relevant milestone
[ ] added relevant label(s)
[ ] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR
[ ] All comments are resolved
[ ] Make sure the JIRA ticket is resolved properly

braingram commented 4 months ago

Closing and re-opening to trigger CI.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.23%. Comparing base (136f1d9) to head (8381431).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #8619 +/- ## ========================================== + Coverage 59.61% 60.23% +0.62% ========================================== Files 391 370 -21 Lines 39287 38636 -651 ========================================== - Hits 23419 23272 -147 + Misses 15868 15364 -504 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 4 months ago

I'm hoping @nden might know some history of these scripts. If it's helpful I'm happy to go through the removed scripts and describe:

what command I attempted for each script (several failed during the imports due to missing modules)
the error encountered for each script

melanieclarke commented 4 months ago

Since we're deleting things, should we also remove the remaining fits_generator script (create_data) and the associated jwst.fits_generator module? As discussed on #8652, the module is no longer used and also contains some broken code.

braingram commented 4 months ago

Since we're deleting things, should we also remove the remaining fits_generator script (create_data) and the associated jwst.fits_generator module? As discussed on #8652, the module is no longer used and also contains some broken code.

I'm not familiar with the fits_generator. It does look largely untested and unused but I haven't given it a thorough look. The create_data script at least ran, output help text when provided with no arguments and did (apparently nothing) when provided a directory 🤷

melanieclarke commented 4 months ago

I'm not familiar with the fits_generator. It does look largely untested and unused but I haven't given it a thorough look.

Okay, we can save it for another time. Thanks!

braingram commented 4 months ago

Okay, we can save it for another time. Thanks!

Works for me. I opened an issue to track investigating it's removal: https://github.com/spacetelescope/jwst/issues/8656

Hopefully it will also serve as a notice (for anyone watching) that we're considering removing it.