JP-3679: Separate resample_spec parameters from resample step

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope

https://jwst-pipeline.readthedocs.io/en/latest/

Other

570 stars 167 forks source link

JP-3679: Separate resample_spec parameters from resample step #8622

Closed melanieclarke closed 3 months ago

melanieclarke commented 4 months ago

Resolves JP-3679

Closes #8621

Remove inheritance link between ResampleSpecStep and ResampleStep, so that the resample_spec step can have a different step parameter spec. Remove parameters and options from the new spec for resample_spec that are only appropriate for imaging data.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

[x] added entry in CHANGES.rst within the relevant release section
[ ] ~updated or added relevant tests~
[x] updated relevant documentation
[x] added relevant milestone
[x] added relevant label(s)
[x] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR
[x] All comments are resolved
[x] Make sure the JIRA ticket is resolved properly

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.38%. Comparing base (155408f) to head (d841cf2).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #8622 +/- ## ========================================== + Coverage 60.36% 60.38% +0.01% ========================================== Files 372 372 Lines 38326 38337 +11 ========================================== + Hits 23137 23148 +11 Misses 15189 15189 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

melanieclarke commented 4 months ago

Regression tests here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1577/

melanieclarke commented 4 months ago

Regression test failures are all unrelated.

melanieclarke commented 4 months ago

Keeping this in draft for now - it will conflict with #8596, which is more urgent. We can discuss these changes after that one is done.

melanieclarke commented 3 months ago

Changes from #8596 are now merged in, so I think this is ready for review now.

Regression tests restarted here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1627/

emolter commented 3 months ago

I just noticed one other thing: the link from this page still leads to resample imaging, not resample spec (even though it says resample spec)

melanieclarke commented 3 months ago

I just noticed one other thing: the link from this page still leads to resample imaging, not resample spec (even though it says resample spec)

Thanks for pointing this out! It looks like there are a few other similar links sprinkled through the documentation. I'll get them updated.

melanieclarke commented 3 months ago

Regression tests show no failures. @tapastro - can you please review for the maintainers?

melanieclarke commented 3 months ago

Build failures are unrelated (#8690), I'll merge when CI finishes.