search

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
558 stars 164 forks source link

Split OutlierDetectionStep into multiple steps #8634

Open stscijgbot-jp opened 2 months ago

stscijgbot-jp commented 2 months ago

Issue JP-3682 was created on JIRA by Brett Graham:

The outlier detection step currently handles several different "modes" in sometimes very different ways:

The docs mention that the parameters for the step are different depending on the mode:

https://jwst-pipeline.readthedocs.io/en/latest/jwst/outlier_detection/arguments.html

The step spec includes many items that are entirely unused in some modes (which is not fully documented).

These modes also expect very different input types and produce different results.

Different modes use different file suffixes, none of which are currently handled by the shared suffix machinery.

It seems reasonable that these should be split into different steps. However this will require:

stscijgbot-jp commented 3 weeks ago

Comment by Ned Molter on JIRA:

I started looking into what is needed here on the cal side.  It looks like something we'd definitely like to do eventually, and I made a quick draft of what it might look like, which can be found in [this draft pull request|[https://github.com/spacetelescope/jwst/pull/8722].]  However I sort of "jumped the gun" as this needs discussion with INS teams and would require parameter reference file changes, so assigning it to David again for input.

stscijgbot-jp commented 1 week ago

Comment by David Law on JIRA:

Initial discussion at the Sep 4 JP meeting; will be considered as part of possible 11.2 work.