spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
570 stars 167 forks source link

JP-3628: Revise coron3 alignment step #8643

Closed penaguerrero closed 3 months ago

penaguerrero commented 4 months ago

Resolves JP-3628

Closes #

This PR addresses aligning only the first integration of the science exposure.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

penaguerrero commented 4 months ago

reg tests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1602/

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.47%. Comparing base (cf91724) to head (0dae781).

Files with missing lines Patch % Lines
jwst/coron/imageregistration.py 81.81% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8643 +/- ## ======================================= Coverage 60.47% 60.47% ======================================= Files 369 369 Lines 38408 38413 +5 ======================================= + Hits 23226 23230 +4 - Misses 15182 15183 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

melanieclarke commented 4 months ago

@penaguerrero - I'm not sure your solution here does what is required. It looks like you are computing the shifts from the first integration, as requested, but then you are shifting only the first integration. I think the shifts computed from the first integration need to be applied to all the subsequent ones.

penaguerrero commented 4 months ago

@melanieclarke thanks! brain freeze :)

penaguerrero commented 3 months ago

reg test: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1625/