Closed jhunkeler closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 59.60%. Comparing base (
136f1d9
) to head (eb692d3
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm seeing a dev version on this docs for this PR:
I think this is expected (since it's not a tagged commit). Is this expected?
Yes, this is expected. This is my local test case:
git tag -a 1.10.100 -m "test tag"
pip install -e '.[test,docs]'
(cd docs && make html)
echo '#' >> docs/Makefile
git describe --long --dirty
1.10.100-0-g590ef5d27-dirty
pip install -e .
Successfully installed jwst-1.10.101.dev0+g590ef5d27.d20240715
(cd docs && make html)
git update-index --assume-unchanged docs/Makefile
pip install -e .
Successfully uninstalled jwst-1.10.101.dev0+g590ef5d27.d20240715
Successfully installed jwst-1.10.100
(cd docs && make html)
Note: We marked the local Makefile
as "unchanged" even though it is. You can tell git to care about this file again by using --no-assume-unchanged
.
git describe --long --dirty
1.10.100-0-g590ef5d27
git update-index --no-assume-unchanged docs/Makefile
git describe --long --dirty
1.10.100-0-g590ef5d27-dirty
Resolves JP-nnnn
Closes #
The last build (#8642) produced:
RTD modifies indexed files in the repository prior to building the documentation. This change should prevent
setuptools_scm
from returning a dirty version (.dXXXXXXXX
suffix).See: https://docs.readthedocs.io/en/stable/build-customization.html#avoid-having-a-dirty-git-index
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release section