spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
561 stars 167 forks source link

JP-3687: fix outlier_detection failures when run outside pipeline #8645

Closed emolter closed 2 months ago

emolter commented 2 months ago

Resolves JP-3687

Closes #8640

This PR addresses a bug that occurs when the outlier_detection step is run outside the pipeline, i.e., loading the datamodel from file instead of passing it in as a ModelContainer. In that case, the wcs.array_shape attribute sometimes does not get saved (saving of this attribute was added to gwcs within the past year, so the behavior is version-dependent). This PR sets the wcs.array_shape explicitly.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

emolter commented 2 months ago

Regression tests started here, using the new GitHub Actions workflow (hope that works!) https://github.com/spacetelescope/RegressionTests/actions/runs/9940607341

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.61%. Comparing base (ccf871a) to head (d433757). Report is 8 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8645 +/- ## ========================================== + Coverage 59.56% 59.61% +0.04% ========================================== Files 391 391 Lines 39285 39287 +2 ========================================== + Hits 23402 23419 +17 + Misses 15883 15868 -15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

emolter commented 2 months ago

separate regtests with same changes started here on Jenkins: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1605/

emolter commented 2 months ago

all regtest failures are unrelated