search

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
570 stars 167 forks source link

Mismatched logic operators in stcal/jump causing operations error #8647

Closed stscijgbot-jp closed 2 months ago

stscijgbot-jp commented 4 months ago

Issue JP-3689 was created on JIRA by Tyler Pauly:

During operations reprocessing, a new error was found during detector1 processing of a MIRI TSO dataset, err log attached. It appears that stcal/jump/jump.py checks if nints > minimum_sigclip_groups on L975, then checks if nints >= minimum_sigclip_groups: on L1003.

I don't know the details of how the segment is chunked for multiprocessing, but it appears as though the number of integrations being processed at this point is equal to the cutoff value, leading to an expected parameter instead being undefined. Suggest fixing L975 to >=.

stscijgbot-jp commented 4 months ago

Comment by David Law on JIRA:

Michael Regan Any thoughts on this?

stscijgbot-jp commented 2 months ago

Comment by David Law on JIRA:

Just discussed this with Michael Regan ; solution is to change line 975 to >=.  This is achieved by spacetelescope/stcal#285

stscijgbot-jp commented 2 months ago

Comment by Tyler Pauly on JIRA:

Fixed by spacetelescope/stcal#285

stscijgbot-jp commented 2 months ago

Comment by David Law on JIRA:

Confirmed that the now-merged stcal avoids the crash in the file jw03730008001_03101_00001-seg004_mirimage_uncal.fits that originally triggered this ticket.