spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
570 stars 167 forks source link

remove unused imports and variables #8651

Closed zacharyburnett closed 4 months ago

zacharyburnett commented 4 months ago

apply Ruff rules F841 and F401 to the excluded modules jwst/fits_generator and jwst/associations

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.59%. Comparing base (ccf871a) to head (3ac4be4). Report is 9 commits behind head on master.

Files Patch % Lines
jwst/fits_generator/template.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8651 +/- ## ========================================== + Coverage 59.56% 59.59% +0.02% ========================================== Files 391 391 Lines 39285 39267 -18 ========================================== Hits 23402 23402 + Misses 15883 15865 -18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zacharyburnett commented 4 months ago

this PR is superseded by #8652, unless we want to only apply the import-related fixes to these modules without un-excluding them

emolter commented 4 months ago

I don't see anything wrong with un-excluding them and going with #8652