spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
570 stars 167 forks source link

JP-3444: update tso photometry to use ApertureStats #8672

Closed jemorrison closed 3 months ago

jemorrison commented 3 months ago

Resolves JP-3444

Closes #8019

This PR addresses when there are nans in the aperture for determining tso photometry. The resulting ecsv file contained NaN values. This update uses the photutils function ApertureStats that screens for Nan values.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.36%. Comparing base (155408f) to head (54015b8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8672 +/- ## ======================================= Coverage 60.36% 60.36% ======================================= Files 372 372 Lines 38326 38326 ======================================= Hits 23137 23137 Misses 15189 15189 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

melanieclarke commented 3 months ago

We should confirm that they definitely want to ignore NaNs in sources, before we merge

Just following up - this is now confirmed, in the JP ticket.

jemorrison commented 3 months ago

@melanieclarke Could you look at the statement I put in the documentation. Does that sound ok ?