Closed jemorrison closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 60.36%. Comparing base (
155408f
) to head (54015b8
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We should confirm that they definitely want to ignore NaNs in sources, before we merge
Just following up - this is now confirmed, in the JP ticket.
@melanieclarke Could you look at the statement I put in the documentation. Does that sound ok ?
Resolves JP-3444
Closes #8019
This PR addresses when there are nans in the aperture for determining tso photometry. The resulting ecsv file contained NaN values. This update uses the photutils function ApertureStats that screens for Nan values.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
[x] added entry in
CHANGES.rst
within the relevant release section[ ] updated or added relevant tests
[x] updated relevant documentation
[x] added relevant milestone
[x] added relevant label(s)
[x] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1620/
[x] All comments are resolved
[ ] Make sure the JIRA ticket is resolved properly