search

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
561 stars 167 forks source link

Emicorr NaNs data for low ngroups #8674

Closed stscijgbot-jp closed 2 months ago

stscijgbot-jp commented 2 months ago

Issue JP-3696 was created on JIRA by David Law:

Per help desk ticket INC202723, EMICORR doesn't work well on data with just 2 groups, and in returning NaN corrections it effectively NaNs out the correction-subtracted science data.  This is a niche edge case, but EMICORR shouldn't apply a correction when the correction is not physical.

stscijgbot-jp commented 2 months ago

Comment by David Law on JIRA:

Fixed by https://github.com/spacetelescope/jwst/pull/8675, and added this data as a test case to the MRS regression testing suite.

stscijgbot-jp commented 2 months ago

Comment by Melanie Clarke on JIRA:

Fixed by #8675

stscijgbot-jp commented 2 weeks ago

Comment by David Law on JIRA:

Tested and working.