spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
561 stars 167 forks source link

JP-3695: Clean up unnecessary copies #8676

Closed penaguerrero closed 1 week ago

penaguerrero commented 2 months ago

Partially Resolves JP-3695

Closes #

This PR addresses removing the unnecessary copies of all steps in the Detector1 pipeline. The same needs to be done for the stage2 pipelines.

Copies are made at the _step.py level, only if the step is not skipped.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 59.34066% with 148 lines in your changes missing coverage. Please review.

Project coverage is 61.83%. Comparing base (7683808) to head (a4741e8). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
jwst/persistence/persistence_step.py 2.04% 48 Missing :warning:
jwst/reset/reset_step.py 10.00% 18 Missing :warning:
jwst/rscd/rscd_step.py 5.55% 17 Missing :warning:
jwst/emicorr/emicorr_step.py 7.69% 12 Missing :warning:
jwst/rscd/rscd_sub.py 35.71% 9 Missing :warning:
jwst/ipc/ipc_corr.py 12.50% 7 Missing :warning:
jwst/ipc/ipc_step.py 25.00% 6 Missing :warning:
jwst/dark_current/dark_current_step.py 73.33% 4 Missing :warning:
jwst/refpix/refpix_step.py 73.33% 4 Missing :warning:
jwst/dq_init/dq_init_step.py 72.72% 3 Missing :warning:
... and 11 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8676 +/- ## ========================================== + Coverage 61.81% 61.83% +0.01% ========================================== Files 377 377 Lines 38915 38905 -10 ========================================== + Hits 24056 24057 +1 + Misses 14859 14848 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

penaguerrero commented 1 month ago

reg tests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1656/

penaguerrero commented 1 week ago

Some changes requested, and needs a changelog entry. We had talked about this in the meetings and had decided that no log entry was needed since it did not change the behavior for users. Thinking about it a bit more, I will go ahead and add a log entry, for tracking purposes.

tapastro commented 1 week ago

Some changes requested, and needs a changelog entry.

We had talked about this in the meetings and had decided that no log entry was needed since it did not change the behavior for users. Thinking about it a bit more, I will go ahead and add a log entry, for tracking purposes.

That's fine, you can mark it with the appropriate no-changelog tag then.

tapastro commented 1 week ago

Latest regtest run was clean: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1741/

Merging!