spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
561 stars 167 forks source link

[SCSB-170] pin Python<3.13 #8703

Closed zacharyburnett closed 1 month ago

zacharyburnett commented 1 month ago

Resolves SCSB-170

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.38%. Comparing base (f6c4095) to head (958240c). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8703 +/- ## ======================================= Coverage 60.38% 60.38% ======================================= Files 372 372 Lines 38337 38337 ======================================= Hits 23148 23148 Misses 15189 15189 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 1 month ago

Would this allow removing the additions in https://github.com/spacetelescope/jwst/pull/8691? If so, I'd say we remove those cibuildwheel changes as the upper pin in this PR is easier to maintain.

zacharyburnett commented 1 month ago

Would this allow removing the additions in #8691? If so, I'd say we remove those cibuildwheel changes as the upper pin in this PR is easier to maintain.

I assumed so when making this PR, but it doesn't appear to have worked that way for drizzlepac so I'll do some testing on that today EDIT: it does work; cibuildwheel does respect the python-requires pin in the metadata. This means we can remove #8691