spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
561 stars 167 forks source link

update dep for stcal to released version #8706

Closed braingram closed 1 month ago

braingram commented 1 month ago

stcal 1.8.0 was released. We can now go back to using the released version (instead of installing from main). This PR updates the required version to >=1.8.0, <1.9.0. This range will allow installing the "dev" version which will appear as stcal-1.8.1.dev... when a new commit is added to stcal.

Regression tests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1646/

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.38%. Comparing base (f6c4095) to head (e4ee465). Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8706 +/- ## ======================================= Coverage 60.38% 60.38% ======================================= Files 372 372 Lines 38337 38337 ======================================= Hits 23148 23148 Misses 15189 15189 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

braingram commented 1 month ago

The regression tests show 9 failures. All related to miri and likely explained by the CRDS update which mentions:

The pipeline developers plan to remove the parameters nhigh and nlow from the outlier detection code, but they first need to be removed from the parameter reference files. This delivery of MIRI outlier detection parameter reference files removes the parameters nhigh and nlow from the reference files. The values of scale are also being updated to 1.0 0.8 from the previous values of 0.5 0.4, as this gave better results when tested on MIRI calibration data. This change will affect MIRI imager, coronagraphic and LRS slit data.