spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope

https://jwst-pipeline.readthedocs.io/en/latest/

Other

570 stars 167 forks source link

JP-3664: Testing changes for numpy 2.0 compatibility #8718

Open tapastro opened 2 months ago

tapastro commented 2 months ago

Resolves JP-3664

Closes #8580

This draft exists to remove jwst's upper pin on numpy, as well as provides a spot to test changes to coron3 unit tests that appear to be incompatible with np2.0.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

[ ] added entry in CHANGES.rst within the relevant release section
[ ] updated or added relevant tests
[ ] updated relevant documentation
[ ] added relevant milestone
[ ] added relevant label(s)
[ ] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR
[ ] All comments are resolved
[ ] Make sure the JIRA ticket is resolved properly

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.68%. Comparing base (1f87cb2) to head (ddd9ecf). Report is 12 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8718 +/- ## ======================================= Coverage 63.68% 63.68% ======================================= Files 375 375 Lines 38689 38691 +2 ======================================= + Hits 24638 24640 +2 Misses 14051 14051 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

melanieclarke commented 1 month ago

8812 fixed most of the coron unit tests with numpy 2, but there's still one check that's barely out of spec on the Linux tests.

I think changing these lines to atol=1e-4, rtol=1e-5 should work: https://github.com/spacetelescope/jwst/blob/217d6601083cb2e9de0440cc099afec77e405b9b/jwst/coron/tests/test_coron.py#L144-L145

zacharyburnett commented 3 weeks ago

started a regtest: https://github.com/spacetelescope/RegressionTests/actions/runs/11555475241/job/32161141720