spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
561 stars 167 forks source link

JP-3682: split outlier detection into separate steps for each mode #8722

Open emolter opened 1 month ago

emolter commented 1 month ago

Resolves JP-3682 Resolves JP-3342

Closes #8634 Closes #7817

This PR addresses splitting outlier detection into separate steps for coronagraphy, IFU, imaging, spectroscopy, and TSO data. This was motivated by large differences in input parameters and algorithms that are implemented for each mode. The parallel separation of the documentation for those modes should also resolve the confusing structure of the docs for outlier detection.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 56.12648% with 111 lines in your changes missing coverage. Please review.

Project coverage is 60.39%. Comparing base (f6c4095) to head (32b8c51). Report is 8 commits behind head on master.

Files Patch % Lines
...t/outlier_detection/outlier_detection_spec_step.py 28.57% 40 Missing :warning:
...st/outlier_detection/outlier_detection_ifu_step.py 17.94% 32 Missing :warning:
...utlier_detection/outlier_detection_imaging_step.py 81.48% 10 Missing :warning:
...st/outlier_detection/outlier_detection_tso_step.py 67.85% 9 Missing :warning:
jwst/pipeline/calwebb_spec3.py 11.11% 8 Missing :warning:
.../outlier_detection/outlier_detection_coron_step.py 76.66% 7 Missing :warning:
jwst/outlier_detection/utils.py 78.26% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8722 +/- ## ========================================== + Coverage 60.38% 60.39% +0.01% ========================================== Files 372 371 -1 Lines 38337 38320 -17 ========================================== - Hits 23148 23142 -6 + Misses 15189 15178 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.