spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
570 stars 167 forks source link

JP-3547: Fix MIRI array sizing for multiple inputs and pixel ratio != 1 #8727

Closed melanieclarke closed 2 months ago

melanieclarke commented 2 months ago

Resolves JP-3547

Fixes an issue discovered during testing for #8596.

For MIRI, when there are multiple input files and pixel_scale_ratio is set to something other than 1.0, the output array size was being computed incorrectly: the pixel_scale_ratio was applied twice. This PR fixes that issue and adds a unit test for the multiple input case.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

melanieclarke commented 2 months ago

Regression tests here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1677

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.55%. Comparing base (e90cafa) to head (f78361d). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8727 +/- ## ======================================= Coverage 60.55% 60.55% ======================================= Files 372 372 Lines 38371 38371 ======================================= Hits 23235 23235 Misses 15136 15136 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

melanieclarke commented 2 months ago

Regtest failures all look unrelated - there are no changes to any spectral resampling products.

drlaw1558 commented 2 months ago

LG2M: Fixes the issue with LRS slit data, and results look as expected in a test case of spec3-combined dithered data.

melanieclarke commented 2 months ago

@tapastro - can you please review for the maintainers?