Update regression tests to remove missing files from tests

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope

https://jwst-pipeline.readthedocs.io/en/latest/

Other

570 stars 167 forks source link

Update regression tests to remove missing files from tests #8730

Closed tapastro closed 2 months ago

tapastro commented 2 months ago

This PR addresses failing regression tests resulting from updated detector1 parameter reference files delivered by NIRCam and MIRI. The new reference files skip the refpix step for MIRI images and skip the persistence step for NIRCam data, resulting in test errors on missing {..}_refpix.fits and {..}_trapsfilled.fits files. This PR removes those suffixes/filenames from the test diffs.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

[ ] added entry in CHANGES.rst within the relevant release section
[x] updated or added relevant tests
[ ] updated relevant documentation
[x] added relevant milestone
[x] added relevant label(s)
[ ] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR
[ ] All comments are resolved
[ ] Make sure the JIRA ticket is resolved properly

tapastro commented 2 months ago

After okifying the downstream results (i.e. ramp, rate, cal) to match the missing persistence entries, regtest run started here to verify the errors are no longer present: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1679/

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.77%. Comparing base (8381a26) to head (0a9dd12). Report is 3 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #8730 +/- ## ========================================== + Coverage 60.63% 60.77% +0.14% ========================================== Files 372 373 +1 Lines 38372 38596 +224 ========================================== + Hits 23267 23458 +191 - Misses 15105 15138 +33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tapastro commented 2 months ago

To be safe, I've started a fresh run after okify'ing the new failures resulting from new CRDS context updates. Here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/

I can clean up the truth files once merged.

melanieclarke commented 2 months ago

I think the regtests look right now - build 1680? The LRS ones are expected with the rmap that needs fixing and the "full_run" one looks like it's probably related to the NIRCam READPATT. Is that right?