Improve AMI observable averaging, error calculations

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope

https://jwst-pipeline.readthedocs.io/en/latest/

Other

570 stars 167 forks source link

Improve AMI observable averaging, error calculations #8733

Open stscijgbot-jp opened 2 months ago

stscijgbot-jp commented 2 months ago

Issue JP-3718 was created on JIRA by Rachel Cooper:

Update AMI observable calculations to average complex quantities, calculate their covariances in Cartesian coordinates, and rotate back to polar coordinates. Then use empirically estimated covariances as error estimates. Do this for fringe amplitudes and phases, and triple-product amplitudes and phases. T3 amps are not currently calculated or stored in outputs, but for completeness we should do this.

stscijgbot-jp commented 2 weeks ago

Comment by Tyler Pauly on JIRA:

Hi Rachel, as part of your updates to AMI code, are you planning on populating and/or utilizing these datamodel keywords? spacetelescope/stdatamodels#342

It looks like those were added to the keyword dictionary as part of the past AMI work but are currently not part of the datamodels. We are trying to determine if they should be kept or removed.

stscijgbot-jp commented 2 weeks ago

Comment by Rachel Cooper on JIRA:

Hi Tyler, I just commented on the Github issue directly, but I can include the necessary changes in the PR for this.