Closed melanieclarke closed 1 month ago
Regression tests here: https://github.com/spacetelescope/RegressionTests/actions/runs/10604279986
Failures are all unrelated.
Attention: Patch coverage is 80.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 60.64%. Comparing base (
f78361d
) to head (e43af51
). Report is 6 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
jwst/outlier_detection/outlier_detection_step.py | 0.00% | 1 Missing :warning: |
jwst/resample/resample.py | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for reviewing @emolter! Since this is a minor technical PR, I'll go ahead and merge when CI completes.
Resolves JP-3719
Closes #8734
For spectral modes with resampling, intermediate files from outlier detection are not being written correctly. There should be files written to the output directory with suffix 'outliers2d'. Instead, there are currently files written to the current directory with suffix 'outlieri2d', and some duplicate files written to the output directory with suffix 'outlier__outlier_s2d.fits'.
This PR should fix these issues by:
I also added a unit test for spectral outlier detection, along with some checks for these kinds of regressions in intermediate file saving.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release section