search

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
570 stars 167 forks source link

Self-calibrated bad pixel step needs to account for MRS residual dark #8770

Closed stscijgbot-jp closed 2 months ago

stscijgbot-jp commented 2 months ago

Issue JP-3738 was created on JIRA by David Law:

User testing of the optional bad pixel self-calibration step has revealed a bug in how the min-combine across input rate files is done for MIRI MRS.  Since the MRS dark can vary significantly, it's possible for an empty-field background image to have rates throughout the FOV that are brighter than for the corresponding science data, hence flagging science pixels as bad.

Moving the bad pixel self calibration step to after the straylight step would not solve the issue, since the straylight step only removes the pedestal from the one science image, not the selfcal images in the association.

Instead, the bad pixel selfcal step should be modified to perform the same kind of subtraction of the median rate in the empty region between MRS channels as is used by the straylight step.

stscijgbot-jp commented 2 months ago

Comment by David Law on JIRA:

Fixed by #8771

stscijgbot-jp commented 2 months ago

Comment by Melanie Clarke on JIRA:

Fixed by #8771

(now merged)

stscijgbot-jp commented 2 months ago

Comment by David Law on JIRA:

Confirmed fixed after merge, closing.