search

spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
559 stars 165 forks source link

Update AMI NRM geometry #8772

Open stscijgbot-jp opened 1 week ago

stscijgbot-jp commented 1 week ago

Issue JP-3739 was created on JIRA by Rachel Cooper:

Update hardcoded as-built mask hole coordinates with in-flight measurements of hole centers. Related: update NRM reference file with same centers. Targeting build 11.2

stscijgbot-jp commented 2 days ago

Comment by David Law on JIRA:

Rachel Cooper What exactly is involved in this?  It sounds like hole coordinates are hard-coded in jwst, is the intent to replace them with use of reference files (new or just updated?) or change the hard-coded values?  Are the new values known and ready to go?

stscijgbot-jp commented 2 days ago

Comment by Rachel Cooper on JIRA:

Hi David Law, currently the hole coordinates are indeed hard-coded in AMI3 ([https://github.com/spacetelescope/jwst/blob/master/jwst/ami/mask_definitions.py)] but they are also duplicated in the header of the recently created NRM reference file, so I think it would probably be better practice to read them from the reference file instead. First I need to calculate the updated coordinates using the distortion matrix that was derived during commissioning, then update the existing reference file with a mask model made using those coordinates (and store them in the header), and then update the jwst code to use those values rather than the mask_definitions.py ones. It might take a little thought as to the best way to modify the code to do this just due to how it's currently set up, but I don't think it will be too involved.

stscijgbot-jp commented 13 hours ago

Comment by David Law on JIRA:

Assigning to the NIRISS team to sort out final details, though it sounds like that should be straight forward.  Rachel Cooper I concur that reading coordinates from the reference file would be better practice than hard-coding duplicates that can drift out of sync.  Once everything is set on the NIRISS side we can loop in Tyler Pauly to discuss best path implementation.