spacetelescope / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
561 stars 167 forks source link

Modify NSClean behavior on full frame images, make aggressiveness user-tunable #8773

Open stscijgbot-jp opened 2 weeks ago

stscijgbot-jp commented 2 weeks ago

Issue JP-3740 was created on JIRA by Timothy Brandt:

This issue addresses two different aspects of NSClean, with a single, combined suggested fix.  The first aspect is the implementation of the full frame correction.  Currently, this correction is done row-by-row, with no coupling between adjacent rows (for which pixels can be read out very close together in time) and with no accounting for the fact that two adjacent pixels can be in different outputs and can be read out at very different times.  The proposed change is to treat the full frame correction as a single correction per output using the subarray implementation.  The corrections for the four outputs may be independent or may be coupled depending on how much information is available to fit.

The second aspect is overfitting or underfitting when more or less of the detector is available to constrain 1/f noise.  The proposed change is to expose a parameter, provisionally to be called aggressiveness, to the user.  This parameter will control the range of frequencies fitted by the 1/f correction and how much to couple or decouple the four outputs in full frame data.