Closed hayescr closed 1 week ago
Attention: Patch coverage is 93.97590%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 64.52%. Comparing base (
4d8e589
) to head (72cb6f0
). Report is 3 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...st/master_background/master_background_mos_step.py | 44.44% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Everything looks good to me now, other than the potential conflict with #8847. I will update from main and run the full set of regression tests.
Tests are running here: https://github.com/spacetelescope/RegressionTests/actions/runs/11902214724
Resolves JP-3746
Closes #8788
This PR adds an option to do a pixel-by-pixel "sigma clipping" with a median and median absolute deviation on MOS background spectra to remove outliers and contaminated spectra when combining inputs into a single spectrum (in combine_1d). This PR also adds an option to perform a median filter on the 1D master background spectrum produced in both master_background and master_background MOS (by default this is off).
Tasks
Build 11.3
(use the latest build if not sure)no-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)docs/
pageokify_regtests
to update the truth filesnews fragment change types...
- ``changes/