Open rcooper295 opened 6 days ago
Attention: Patch coverage is 24.56140%
with 172 lines
in your changes missing coverage. Please review.
Project coverage is 62.52%. Comparing base (
5a2d0cd
) to head (8f38d3f
). Report is 19 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Resolves JP-3739
This PR addresses JP-3739, which includes updates associated with the mask geometry. The NRM reference file is being updated to be distorted by the affine transform parameters derived during commissioning, and the datamodel definitions have also been updated to allow the AMI3 code to read the mask hole centers and other pupil geometry from the reference file datamodel, rather than it being hardcoded in mask_definitions.py. The new
mask_definition_ami.NRM_definition
largely keeps the same structure asmask_definitions.NRM_mask_definitions
but is simplified because there is only one NRM on JWST. A special input argument for affine2d, 'commissioning' is the new default and uses the commissioning affine parameters for the analytical form of the mask (rather than distortion-free or rotation-only).(to be merged after #8846
Tasks
Build 11.3
(use the latest build if not sure)no-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)docs/
pageokify_regtests
to update the truth filesnews fragment change types...
- ``changes/