spacetelescope / jwst_backgrounds

This tool retrieves background intensity spectra relevant for JWST
Other
8 stars 7 forks source link

Tier Two Community Software Standards Second Pass #14

Closed mfixstsci closed 3 years ago

mfixstsci commented 3 years ago

https://github.com/spacetelescope/ins-jwst-community-software/#contents

pep8speaks commented 3 years ago

Hello @mfixstsci, Thank you for updating !

Line 165:30: W605 invalid escape sequence '\S' Line 166:29: W605 invalid escape sequence '[' Line 166:44: W605 invalid escape sequence ']' Line 207:35: W605 invalid escape sequence '[' Line 207:50: W605 invalid escape sequence ']' Line 230:9: E741 ambiguous variable name 'l' Line 258:9: E741 ambiguous variable name 'l' Line 456:29: W605 invalid escape sequence '\S' Line 456:36: W605 invalid escape sequence '\S'

Line 129:9: E722 do not use bare 'except' Line 164:14: E225 missing whitespace around operator Line 254:26: E126 continuation line over-indented for hanging indent

Line 12:1: E302 expected 2 blank lines, found 1

Comment last updated at 2021-08-02 15:47:55 UTC
mfixstsci commented 3 years ago

@pontoppi would you be interested in creating the citation for this tool? https://github.com/spacetelescope/ins-jwst-community-software/blob/master/tier2_standards/citation_information.md

Once we add that, I believe we will meet all of the tier-two standards.

mfixstsci commented 3 years ago

Removing .travis.yml and including github actions CI

https://github.com/mfixstsci/jwst_backgrounds/actions/runs/1038799458

Here is the latest build.

mfixstsci commented 3 years ago

Looks like everything is here.