search

spacetelescope / jwst_gtvt

Other
10 stars 11 forks source link

Add Horizons Quantities `V` and `elong` #92

Open mfixstsci opened 6 months ago

mfixstsci commented 6 months ago

Add elongation angle and v mag to dataframe from Horizon's API

pep8speaks commented 6 months ago

Hello @mfixstsci! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 18:80: E501 line too long (86 > 79 characters) Line 59:30: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 82:80: E501 line too long (85 > 79 characters) Line 83:80: E501 line too long (81 > 79 characters) Line 86:80: E501 line too long (80 > 79 characters) Line 91:80: E501 line too long (83 > 79 characters)

Line 39:1: E731 do not assign a lambda expression, use a def Line 53:80: E501 line too long (82 > 79 characters) Line 69:80: E501 line too long (99 > 79 characters) Line 125:80: E501 line too long (83 > 79 characters) Line 162:80: E501 line too long (86 > 79 characters) Line 190:80: E501 line too long (80 > 79 characters) Line 227:80: E501 line too long (83 > 79 characters) Line 273:80: E501 line too long (87 > 79 characters) Line 281:80: E501 line too long (87 > 79 characters) Line 355:80: E501 line too long (89 > 79 characters) Line 356:80: E501 line too long (160 > 79 characters) Line 361:80: E501 line too long (80 > 79 characters) Line 367:80: E501 line too long (86 > 79 characters) Line 399:80: E501 line too long (86 > 79 characters) Line 421:80: E501 line too long (83 > 79 characters) Line 424:80: E501 line too long (86 > 79 characters) Line 476:80: E501 line too long (81 > 79 characters) Line 481:80: E501 line too long (111 > 79 characters) Line 573:80: E501 line too long (86 > 79 characters) Line 607:12: E262 inline comment should start with '# ' Line 633:80: E501 line too long (87 > 79 characters) Line 716:80: E501 line too long (111 > 79 characters) Line 730:80: E501 line too long (80 > 79 characters)

Line 13:44: E712 comparison to True should be 'if cond is True:' or 'if cond:' Line 37:80: E501 line too long (85 > 79 characters) Line 42:80: E501 line too long (85 > 79 characters) Line 52:80: E501 line too long (86 > 79 characters) Line 63:80: E501 line too long (81 > 79 characters) Line 73:80: E501 line too long (80 > 79 characters) Line 81:80: E501 line too long (81 > 79 characters) Line 90:80: E501 line too long (83 > 79 characters)

Line 49:80: E501 line too long (85 > 79 characters) Line 50:80: E501 line too long (156 > 79 characters)

Line 43:80: E501 line too long (82 > 79 characters) Line 48:80: E501 line too long (85 > 79 characters) Line 49:80: E501 line too long (156 > 79 characters)

Comment last updated at 2024-03-22 14:25:08 UTC
bholler commented 5 months ago

@mfixstsci Final version looks good! I like seeing the V mag and elongation angle quantities included in the output to the terminal.

mfixstsci commented 5 months ago

@bholler awesome! glad we were able to get this in. All of the tests are passing too 👍 As soon as you approve, we can merge it in.