spacetelescope / jwst_mast_query

Command line tool for querying MAST and downloading JWST data products
BSD 3-Clause "New" or "Revised" License
18 stars 11 forks source link

Restore ability to download guidestar data #55

Closed bhilbert4 closed 1 year ago

bhilbert4 commented 1 year ago

Tweaks to the behavior of the guide star keyword and filtering behavior in order to restore the ability to download the guidestar data. Previously the product_filter function was always being called with the option set to remove the guide star entries.

This PR also adds the guidestar_data_only argument. If this is set to True, then the science products will be filtered out and only the guidestar data will be downloaded. This is inspired by some upcoming work that will design a calibration pipeline for guidestar data.

bhilbert4 commented 1 year ago

Also, guide star filtering was being done twice: once in product_search() and a second time in product_filter(). Since we are talking about filtering guide star entries, I kept the code in product_filter(), and removed it from product_search().

bhilbert4 commented 1 year ago

Testing with program 1068, using guidestars and guidestar_data_only from both the command line and from within the config file all work as expected.

bhilbert4 commented 1 year ago

@arminrest any comments on this?