spacetelescope / jwst_validation_notebooks

JWST Pipeline Validation Notebooks
BSD 3-Clause "New" or "Revised" License
5 stars 23 forks source link

LRS notebooks now use inflight data for validation #248

Closed ktmurray closed 1 year ago

ktmurray commented 1 year ago

These changes now pull and use the inflight data for analysis, as well as correct the mistake that caused the assertion error in the slit notebook.

skendrew commented 1 year ago

thanks @ktmurray! Reviewed the notebooks and they will need some further updates before we can merge.

Slit:

Slitless:

Thanks!

cracraft commented 1 year ago

Also, the notebook cells need to be cleared before they can be put into the repo. Before re-submitting to the PR, please use the Kernel > Restart & Clear Output option.

ktmurray commented 1 year ago

Okay this should have updated the pull request with the files addressing your comments - let me know if it worked!

skendrew commented 1 year ago

Looks good from my side @ktmurray! If @cracraft is happy with the format, this is good to merge.

cracraft commented 1 year ago

All tests have passed, merging into repo.