Closed ktmurray closed 1 year ago
thanks @ktmurray! Reviewed the notebooks and they will need some further updates before we can merge.
Slit:
Slitless:
Thanks!
Also, the notebook cells need to be cleared before they can be put into the repo. Before re-submitting to the PR, please use the Kernel > Restart & Clear Output option.
Okay this should have updated the pull request with the files addressing your comments - let me know if it worked!
Looks good from my side @ktmurray! If @cracraft is happy with the format, this is good to merge.
All tests have passed, merging into repo.
These changes now pull and use the inflight data for analysis, as well as correct the mistake that caused the assertion error in the slit notebook.