Fix NRCB5_MASKLWB subarray name

spacetelescope / mirage

This code can be used to generate simulated NIRCam, NIRISS, or FGS data

https://mirage-data-simulator.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

39 stars 41 forks source link

Fix NRCB5_MASKLWB subarray name #744

Closed bhilbert4 closed 3 years ago

bhilbert4 commented 3 years ago

This PR corrects the DMS subarray name that is associated with the NRCB5_MASKLWB aperture name in the PRD. The subarray size is 320x320 pixels, not the 640x640 pixels that the associated SW channel subarrays are.

bhilbert4 commented 3 years ago

Version 4.9.1rc0 of jupyter-core fixed the problem found in version 4.9.0. It sounds like 4.9.1 is going to be released imminently with this fix, so let's see if it is. If so, we can remove the update to setup.py and return this PR to its regularly scheduled programming, which is simply fixing the subarray name in the config file. https://github.com/jupyter/jupyter_core/issues/246

bhilbert4 commented 3 years ago

Ok, this is now ready for a (trivial) review. The RTD failures have been resolved with #745