spacetelescope / mirage

This code can be used to generate simulated NIRCam, NIRISS, or FGS data
https://mirage-data-simulator.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
39 stars 41 forks source link

[WIP]: Use niriss_ghost repo as source of ghost-related code #754

Open bhilbert4 opened 2 years ago

bhilbert4 commented 2 years ago

This PR shifts the calculation of optical ghost locations to the niriss_ghost repository, which is maintained by the NIRISS team. This repository contains the master copy of the ghost gap file, as well as several functions which calculate a corresponding ghost's location on the detector given a source's location. By switching Mirage over to use this repo, we can be sure that it always has access to the latest ghost gap file and algorithms.

These updates have not been tested yet. The functions in niriss_ghost are going to be updated shortly. We should wait for these updates to be made and make any necessary tweaks to Mirage before doing any testing.