search

spacetelescope / pandokia

Regression tests framework.
Other
2 stars 4 forks source link

Makewarn #11

Closed stscieisenhamer closed 6 years ago

stscieisenhamer commented 6 years ago

Changing the condition that a "complete environment cannot be provided" from an Exception to a Warnings. Others more fluent in this package may know otherwise, but for the apparent use of the Envgetter, not having every single item of an environment reproducible would not have significant impact on operation. Or so I'm guessing from the error case I'm hitting where the object is digging into bash functions and trying to define local bash variables.

jhunkeler commented 6 years ago

Already merged as part of the py3k port effort:

commit e985797331df0287c1e57b4f67f82cef42c58768
Merge: 931710c fa4bc07
Author: Joseph Hunkeler <jhunkeler@users.noreply.github.com>
Date:   Wed Nov 29 12:18:21 2017 -0500

    Merge pull request #13 from stscieisenhamer/envgetterfix

    Change environment exception to warning