search

spacetelescope / pandokia

Regression tests framework.
Other
2 stars 4 forks source link

pytest 3.x warnings #2

Open pllim opened 7 years ago

pllim commented 7 years ago

Fun fun fun... I see this when running pytest 3.0.4 on something else. I was not even using pandokia but somehow pytest has a hook to it in my "stsci" environment.

WI1 .../python2.7/site-packages/pandokia/helpers/pytest_plugin.py:375 'pytest_runtest_makereport' hook uses deprecated __multicall__ argument
WC1 None pytest_funcarg__pdk_test_name: declaring fixtures using "pytest_funcarg__" prefix is deprecated and scheduled to be removed in pytest 4.0.  Please remove the prefix and use the @pytest.fixture decorator instead.
ariedel commented 5 years ago

The warning (on pytest 3.5.2, the version in JWST's Third Party 9.2):

pytest_funcarg__pdk_test_name: declaring fixtures using "pytest_funcarg__" prefix is deprecated and scheduled to be removed in pytest 4.0. Please remove the prefix and use the @pytest.fixture decorator instead.

And on a more modern version of pytest (4.6.2) it gives this error: INTERNALERROR> PluginValidationError: unknown hook 'pytest_funcarg__pdk_test_name' in plugin <module 'pandokia.helpers.pytest_plugin' from '/Users/riedel/anacondab/envs/pandeia_9.2/lib/python2.7/site-packages/pandokia-2.4.1-py2.7.egg/pandokia/helpers/pytest_plugin.py'>

Fortunately, that @pytest.fixture decorator is a drop-in replacement (I tried it).