search

spacetelescope / pandokia

Regression tests framework.
Other
2 stars 4 forks source link

Change location of writing 'START' and related info in PDK_LOG #23

Closed oiintam closed 6 years ago

oiintam commented 6 years ago

There is an issue when import test results from log to the Pandokia web page. The results of the first set of test will be missing in Pandokia even though the results are present in the test log. It is because the test results are posted before the 'START' block and Pandokia can not relate any test_run associate with the those test results (since the test run is defined after 'START'). Therefore, those results will be missing in Pandokia web page. Example and details in https://github.com/STScI-SSB/pandeia/issues/3865#issuecomment-394691496. Since it is caused by an ordering issue, moving the location of the 'START' and related info will fix the problem.

CC @vglaidler @cslocum

oiintam commented 6 years ago

@jhunkeler Please let me know if this change causes any issue with other code in Pandokia. Thank you. :)

cslocum commented 6 years ago

This looks great @oiintam. Nice job.

jhunkeler commented 6 years ago

Nice job, @oiintam. This two-step approach makes far more sense than the original implementation. 👍