search

spacetelescope / pandokia

Regression tests framework.
Other
2 stars 4 forks source link

Replace deprecated option '-d' in 'fitsdiff' with '-r' #3

Closed mcara closed 7 years ago

mcara commented 7 years ago

Regression tests contain multiple deprecation warnings similar to:

COMPARE: acs_square_drz.fits
['fitsdiff', '-d', '1e-07', '-k', 'origin,filename,date,iraf-tlm,fitsdate,upwtim,wcscdate,upwcsver,pywcsver,prod_ver, rulefile,history', 'acs_square_drz.fits', 'reference_square.fits']
WARNING: AstropyDeprecationWarning: "-d" ("--difference-tolerance") was deprecated in version 2.0 and will be removed in a future version. Use "-r" ("--relative-tolerance") instead. [astropy.io.fits.scripts.fitsdiff]

This is due to addition of absolute tolerance comparison in https://github.com/astropy/astropy/pull/4729

This PR renames option -d to -r in order to get rid of deprecation warnings.

mcara commented 7 years ago

No feedback... Merging ...

pllim commented 7 years ago

:+1:

What black magic needs to be done to have regression test use this fixed pandokia?