Big Regression - Githubissues

spacetelescope / pandokia

Regression tests framework.

Other

2 stars 4 forks source link

Big Regression #38

Open jhunkeler opened 5 years ago

jhunkeler commented 5 years ago

The commit made on 12/03 undid a lot of py2->py3 work:

https://github.com/spacetelescope/pandokia/commit/1c98a3c5003138ecff6c63411d4b532907a3146f#diff-d8acb544ad4247a6c4aef20f471e1455

You might want to review the changes it replaced. If you noticed a lot of new bugs lately this might at least one source of your pain.

jhunkeler commented 5 years ago

(and PEP8 changes...)

cdsontag commented 5 years ago

Thanks @jhunkeler ! We will definitely have to look into that and clear up all of our understanding of what versions of pandokia we are using. Yikes - that commit looks like a mistake.

CC @cslocum @oiintam @vglaidler

cslocum commented 5 years ago

@jhunkeler can you please elaborate? I notice the old-style print statements which will have to be fixed, but I assume you are referring to something else. I'm actually not sure why some of those changes were made. I'll discuss with @oiintam.

cslocum commented 5 years ago

@jhunkeler are you currently using this version of Panokia? I was under the impression that you were not, which is why we did not consult you. If this is currently breaking things for you, we will fix it ASAP.

jhunkeler commented 5 years ago

Neg, we're not using pandokia. I only made the issue to point out that weird spacing was added back and py3 compatibility was broken as a result of that merge

vglaidler commented 5 years ago

Thanks @jhunkeler . From what I can see of the commit message (..am I missing some way to see the whole thing?)

update pandokia files from iraf@ssb c96...

this looks likely to have been an attempt to pick up changes that had been made in the c96 version we had been using. I don't see it in a PR tho, hm.

vglaidler commented 5 years ago

Here's a snapshot of the network map. Looks like this change was made directly to master, then pulled in as part of the glitch work with a message (not shown) as "merge from master".