search

spacetelescope / pandokia

Regression tests framework.
Other
2 stars 4 forks source link

fix bug I introduced - debug_fd does not exist unless debug=True #59

Closed cdsontag closed 5 years ago

cdsontag commented 5 years ago

I introduced this bug in #55 where I added a debug line. I am SOO sorry... :-)

I noticed this issue in this test run:

where this happens:

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/data1/miniconda3/envs/pyetc_tp22dev1_linux_py36/lib/python3.6/site-packages/pandokia/helpers/runner_minipyt.py", line 736, in process_file
    run_test_class(rpt, module, name, ob, test_order)
  File "/data1/miniconda3/envs/pyetc_tp22dev1_linux_py36/lib/python3.6/site-packages/pandokia/helpers/runner_minipyt.py", line 568, in run_test_class
    run_test_class_single(rpt, mod, name, ob, test_order)
  File "/data1/miniconda3/envs/pyetc_tp22dev1_linux_py36/lib/python3.6/site-packages/pandokia/helpers/runner_minipyt.py", line 388, in run_test_class_single
    debug_fd.write('bailing out early trying to instantiate class %s, named %s, for: %s\n' % (ob, name, exception_str))
NameError: name 'debug_fd' is not defined
vglaidler commented 5 years ago

Can you please describe how you tested the fix?

cdsontag commented 5 years ago

Can you please describe how you tested the fix?

I didn't. It's that trivial. (did you see that change?)

cdsontag commented 5 years ago

Thank you @vglaidler :)