search

spacetelescope / pandokia

Regression tests framework.
Other
2 stars 4 forks source link

Make "import string" Python 3 compatible #6

Closed pllim closed 6 years ago

pllim commented 7 years ago

A sub-issue of #5. There is a need to fix the error below:

("can't read configuration file", 'basic2d_lev1a.xml')
Traceback (most recent call last):
  File "/srv/iraf/bldtmp/pidS/p/envs/dev/lib/python3.5/site-packages/stsci_regtest/pdkregress.py", line 176, in runtest
    config = configuration.regtest_read(file)
  File "/srv/iraf/bldtmp/pidS/p/envs/dev/lib/python3.5/site-packages/stsci_regtest/configuration.py", line 29, in regtest_read
    config = read(file)
  File "/srv/iraf/bldtmp/pidS/p/envs/dev/lib/python3.5/site-packages/stsci_regtest/configuration.py", line 50, in read
    reader = Config_reader(filename)
  File "/srv/iraf/bldtmp/pidS/p/envs/dev/lib/python3.5/site-packages/stsci_regtest/configuration.py", line 73, in __init__
    self.buffer = string.join(fd.readlines(), "")
AttributeError: module 'string' has no attribute 'join'

('Exception running test:', AttributeError("module 'string' has no attribute 'join'",))
Traceback (most recent call last):
  File "/srv/iraf/bldtmp/pidS/p/envs/dev/lib/python3.5/site-packages/stsci_regtest/pdkregress.py", line 176, in runtest
    config = configuration.regtest_read(file)
  File "/srv/iraf/bldtmp/pidS/p/envs/dev/lib/python3.5/site-packages/stsci_regtest/configuration.py", line 29, in regtest_read
    config = read(file)
  File "/srv/iraf/bldtmp/pidS/p/envs/dev/lib/python3.5/site-packages/stsci_regtest/configuration.py", line 50, in read
    reader = Config_reader(filename)
  File "/srv/iraf/bldtmp/pidS/p/envs/dev/lib/python3.5/site-packages/stsci_regtest/configuration.py", line 73, in __init__
    self.buffer = string.join(fd.readlines(), "")
AttributeError: module 'string' has no attribute 'join'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/srv/iraf/bldtmp/pidS/p/envs/dev/lib/python3.5/site-packages/stsci_regtest/pdkregress.py", line 136, in run
    self.runtest(file, pdkr)
  File "/srv/iraf/bldtmp/pidS/p/envs/dev/lib/python3.5/site-packages/stsci_regtest/pdkregress.py", line 181, in runtest
    self.writelog("?", "Couldn't read configuration file", file)
  File "/srv/iraf/bldtmp/pidS/p/envs/dev/lib/python3.5/site-packages/stsci_regtest/pdkregress.py", line 504, in writelog
    other = string.join(list(map(str, args)), ",")
AttributeError: module 'string' has no attribute 'join'

See https://ssb.stsci.edu/pandokia/pandokia.cgi?query=summary&qid=3144