spacetelescope / pandokia

Regression tests framework.
Other
2 stars 4 forks source link

found old has_key() usages to fix for py3 #63

Closed cdsontag closed 4 years ago

cdsontag commented 4 years ago

The first one bit Oi In today during a pdk import. The second one is just a comment in an unused test script (which imports pyraf!! wow).

@vglaidler it would be lovely if you would double-check my work, but I am going to merge now to get glitch back on track. glitch uses master, so we don't need to update our TP's with this fix in any kind of hurry. Next TP version will grab it.

vglaidler commented 4 years ago

Looks good to me @sontag, thanks!

Historical note: I see the second one was located in the stsci_regtest subtree. Regtest was the predecessor of Pandokia, and was written explicitly (and solely, IIRC) for IRAF and PyRAF tests. Backwards compatibility with regtest was one of our constraints. :)